Added delegate/undelegate fallbacks to bind/unbind and fixed broken Zepto/Dojo delegate implementations #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can.delegate
andcan.undelegate
(in util/LIBRARY/LIBRARY.js) don't implement fallback binding for objects for non-elements and objects that don't explicitly define delegate/undelegate. (#754)This is an updated pull request based on the minor branch instead of master. (see #758 for the original pull request)
Additionally, the existing Zepto/Dojo delegate methods completely fail in cases where the
selector === ""
.This pull request fixes these issues by having
can.delegate/undelegate
fallback to theircan.bind/unbind
counterparts in cases where normal object instances don't implement delegate/undelegate. Also included is the addition ofcan/util/event
andcan/control/modifier
tests to the tests run with all libraries intest/*
as well as addingtest/jquery-2.html
totest/index.html
.For example in util/jquery/jquery.js:
The problem with this is there are portions of the CanJS codebase that call
.delegate
instead of.bind
. Specifically, modifier functions like incan/control/modifier
.