Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address charm review comments #11

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Address charm review comments #11

merged 3 commits into from
Jul 16, 2024

Conversation

kelkawi-a
Copy link
Collaborator

This PR:

  • Addresses charm listing review comments in Review Charm for Listing #10
  • Adds a config_changed hook which was previously missing.
  • Adds README badges.

@kelkawi-a kelkawi-a requested review from gtato and mertalpt July 8, 2024 09:06
@kelkawi-a kelkawi-a mentioned this pull request Jul 8, 2024
Closed
@kelkawi-a kelkawi-a requested a review from AmberCharitos July 15, 2024 14:46
AmberCharitos
AmberCharitos approved these changes Jul 16, 2024
View reviewed changes
Copy link

@AmberCharitos AmberCharitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@kelkawi-a kelkawi-a merged commit d007065 into main Jul 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmberCharitos AmberCharitos AmberCharitos approved these changes

@mertalpt mertalpt mertalpt approved these changes

@gtato gtato Awaiting requested review from gtato

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelkawi-a @mertalpt @AmberCharitos