Add airbyte rock #12
Merged
Add airbyte rock #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelkawi-a
force-pushed
the
ui-rock
branch
5 times, most recently
from
da4d4f0 to
4a0dcb4
Compare
kelkawi-a
force-pushed
the
ui-rock
branch
21 times, most recently
from
9d78d17 to
8205eb4
Compare
kelkawi-a
force-pushed
the
ui-rock
branch
6 times, most recently
from
29dcfb0 to
2c5a122
Compare
mertalpt
approved these changes
Oct 7, 2024
AmberCharitos
approved these changes
Oct 7, 2024
| override: replace | ||
| summary: "airbyte-webapp service" | ||
| startup: disabled | ||
| command: "/usr/bin/pnpm -C airbyte-webapp start" |
There was a problem hiding this comment.
question: any reason this needs to be executed by the root user? And not set up permissions as outlined here: https://discourse.ubuntu.com/t/unifying-user-identity-across-snaps-and-rocks/36469
There was a problem hiding this comment.
I can't think of a specific reason. Once I set permissions, would I run it as /bin/pnpm?
There was a problem hiding this comment.
You'd run it the same way, it would just be run by the daemon user as opposed to root.
There was a problem hiding this comment.
As per MM conversation, this seems to have introduced a permission issue with the staged binaries. Will defer for now.
linostar
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds the Airbyte webapp from source using Rockcraft, and builds the Airbyte UI charm with it.