Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS part 1: Enable TLS if cert is available #164

Merged
merged 45 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
2f6dc2b
Green import
sed-i Jun 13, 2023
f726fc3
Green integration
sed-i Jun 13, 2023
8e620c1
Fixes
sed-i Jun 14, 2023
4f6062e
separate reload logic and remove certs when not used
lucabello Jun 14, 2023
22f1607
Fix utests
sed-i Jun 14, 2023
965cc90
Remove private key password
sed-i Jun 14, 2023
d06bbf9
Remove private key password
sed-i Jun 14, 2023
8aefe7b
Fixes
sed-i Jun 14, 2023
8cea8a7
make tls a unit concern instead of app
lucabello Jun 15, 2023
06e6ee3
Fixes
sed-i Jun 15, 2023
07e8d0d
Add web_external_url as extra SAN
sed-i Jun 16, 2023
b6b0d86
Doc fix
sed-i Jun 20, 2023
31bec5e
fetch-lib
sed-i Jun 20, 2023
b2c374b
Remove CodeQL workflow
sed-i Jun 20, 2023
85043c0
partial peer relation cleanup on relation broken
lucabello Jun 20, 2023
a2193a7
Push tls files on upgrade
sed-i Jun 20, 2023
165b148
Add a FIXME
sed-i Jun 21, 2023
dc4da6d
gitignored egg-infos
PietroPasotti Jun 21, 2023
34ae560
included tls config in hash diff
PietroPasotti Jun 21, 2023
c36c341
config utils split to other file
PietroPasotti Jun 21, 2023
e8aa5a7
fix peer relation lifecycle
lucabello Jun 21, 2023
8d1d7b5
Fix utest patch
sed-i Jun 22, 2023
53178f7
Don't need 'container_pebble_ready' after 'begin_with_initial_hooks'
sed-i Jun 22, 2023
556e423
Fix import statement
sed-i Jun 22, 2023
6ca05cd
Add itest
sed-i Jun 22, 2023
46cfdfd
Add upgrade to itest
sed-i Jun 22, 2023
000e1d8
fixed types on _get_raw_config_and_templates
PietroPasotti Jun 22, 2023
0178964
fixed imports
PietroPasotti Jun 22, 2023
35e80fd
Drop no longer needed debug logs
sed-i Jun 22, 2023
bd99b42
Modify relation-broken handler
sed-i Jun 22, 2023
a6199ed
Address review comments
sed-i Jun 22, 2023
29beb5b
Refactor with config builder
sed-i Jun 27, 2023
e02848c
Refactor with workload manager
sed-i Jun 27, 2023
536984f
Woke
sed-i Jun 27, 2023
7bcb957
Fix handling of templates section
sed-i Jun 28, 2023
6f5b717
Drop StoredState; cleanup
sed-i Jun 28, 2023
0df3214
refactored some readiness code in workloadmanager
PietroPasotti Jun 28, 2023
3c33fa0
removed unnecessary fstring
PietroPasotti Jun 28, 2023
d30e3d5
Drop am lib changes (there's a separate issue for that already)
sed-i Jun 29, 2023
a7f035d
Fix some utests
sed-i Jun 29, 2023
7b71c76
Address review comments
sed-i Jun 29, 2023
3d34ca9
fetch-lib
sed-i Jul 4, 2023
edc5b99
Skip some utests because of https://github.com/canonical/operator/iss…
sed-i Jul 4, 2023
9edc14f
Lint
sed-i Jul 4, 2023
bff34be
Address review comments
sed-i Jul 5, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 0 additions & 66 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ build/
.idea/
.tox/
.mypy_cache
**/*.egg-info/
1 change: 1 addition & 0 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ bases:
channel: "20.04"
parts:
charm:
charm-binary-python-packages: [cryptography, jsonschema]
build-packages:
- git
3 changes: 2 additions & 1 deletion lib/charms/alertmanager_k8s/v0/alertmanager_dispatch.py
sed-i marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def __init__(self, *args):

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 7
LIBPATCH = 8

# Set to match metadata.yaml
INTERFACE_NAME = "alertmanager_dispatch"
Expand Down Expand Up @@ -172,6 +172,7 @@ def _on_relation_changed(self, event: ops.charm.RelationChangedEvent):

def get_cluster_info(self) -> List[str]:
"""Returns a list of ip addresses of all the alertmanager units."""
# FIXME need to tell prometheus that `scheme: https`.
alertmanagers = [] # type: List[str]
relation = self.charm.model.get_relation(self.name)
if not relation:
Expand Down
Loading
Loading