add prometheus scrape jobs for all units #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves some logic for parsing peer addresses for WorkloadManager from the charm to WorkloadManager. The reason for this is that the charm will be extended to use peer addresses for other configurations (metrics), and this makes it easier to add that functionality.
Moves logic deciding whether the charm's address uses http or https to a reusable location. This was done to reuse this logic elsewhere in the charm.
Previously, AlertmanagerCharm provided metrics only for the leader. This updates AlertmanagerCharm.self_scraping_job to generate a jobs list for MetricsEndpointProvider that includes all units, not just the leader. Closes #151
sed-i
reviewed
Jun 12, 2024
This uses target expansion provided by the prometheus charm that removes the need to explicitly define each target. The downside of this is that they're rendered as IPs rather than FQDNs, which does not support TLS for the scrape
This reverts commit a36584e.
sed-i
reviewed
Jun 15, 2024
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
sed-i
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #151
Solution
Extends AlertmanagerCharm.self_scraping_job() to include all units, not just the leader, for metrics scraping.
Testing Instructions
Upgrade Notes
Upgrade should happen seemlessly. Nothing has changed to affect upgrades