Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): use rate_interval instead of interval #278

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

lucabello
Copy link
Contributor

Issue

Closes #274.

Solution

Use $__rate_interval instead of $__interval.

@lucabello lucabello requested a review from a team as a code owner August 7, 2024 08:06
@mmkay
Copy link
Contributor

mmkay commented Aug 7, 2024

One thing to potentially consider here: https://hoelz.ro/blog/use-caution-when-using-rate_interval-along-with-increase

This might change the values scale visible in the dashboards. Might be surprising to some?

I wonder if we shouldn't change the variable only in the panels that use rate(.

@lucabello
Copy link
Contributor Author

You're right, that replace was too lazy :) Now we only changed to $__rate_interval in rate() queries.

Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more and we're good to go.

src/grafana_dashboards/alertmanager_rev5.json.tmpl Outdated Show resolved Hide resolved
src/grafana_dashboards/alertmanager_rev5.json.tmpl Outdated Show resolved Hide resolved
src/grafana_dashboards/alertmanager_rev5.json.tmpl Outdated Show resolved Hide resolved
src/grafana_dashboards/alertmanager_rev5.json.tmpl Outdated Show resolved Hide resolved
lucabello and others added 4 commits August 8, 2024 11:38
Co-authored-by: Mateusz Kulewicz <mateusz.kulewicz@canonical.com>
Co-authored-by: Mateusz Kulewicz <mateusz.kulewicz@canonical.com>
Co-authored-by: Mateusz Kulewicz <mateusz.kulewicz@canonical.com>
Co-authored-by: Mateusz Kulewicz <mateusz.kulewicz@canonical.com>
@lucabello lucabello merged commit aa12877 into main Aug 12, 2024
13 checks passed
@lucabello lucabello deleted the fix/dashboards-rate-interval branch August 12, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panels in the alertmanager dashboard are emtpy
2 participants