Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add log forwarding and fetch-lib #21

Merged
merged 4 commits into from
Apr 10, 2024
Merged

add log forwarding and fetch-lib #21

merged 4 commits into from
Apr 10, 2024

Conversation

lucabello
Copy link
Contributor

@lucabello lucabello commented Mar 15, 2024 •
edited
Loading

lucabello and others added 2 commits March 15, 2024 15:59
@lucabello
fix dashboard and add alert rules (#22)
609de94 
* fix dashboard and add alert rules

* tox fmt
@lucabello
minor fix alert rule
656170f
sed-i
sed-i reviewed Mar 15, 2024
View reviewed changes
src/charm.py Show resolved Hide resolved
PietroPasotti
PietroPasotti requested changes Apr 5, 2024
View reviewed changes
Copy link

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR does too many things at once.
Can we break it up?

@lucabello
Copy link
Contributor Author

The bulk of the changed files is due to charmcraft fetch-lib. The actual changes are one line in the charm (to instantiate LogForwarder), a dashboard change, and a new alert rule file.

I think that's fine, but if you'd rather split it into 4 PRs I can go ahead and do that!

@lucabello lucabello requested a review from PietroPasotti April 8, 2024 07:58
PietroPasotti
PietroPasotti approved these changes Apr 10, 2024
View reviewed changes
Copy link

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PietroPasotti
PietroPasotti approved these changes Apr 10, 2024
View reviewed changes
Copy link

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PietroPasotti
PietroPasotti approved these changes Apr 10, 2024
View reviewed changes
Copy link

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucabello lucabello merged commit 986d5d3 into main Apr 10, 2024
13 checks passed
@lucabello lucabello deleted the feature/log-forwarding branch April 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i left review comments

@PietroPasotti PietroPasotti PietroPasotti approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@dstathis dstathis Awaiting requested review from dstathis

@IbraAoad IbraAoad Awaiting requested review from IbraAoad

@mmkay mmkay Awaiting requested review from mmkay

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lucabello @PietroPasotti @sed-i