Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGES.txt #39

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Update CHANGES.txt #39

merged 6 commits into from
Aug 6, 2024

Conversation

petesfrench
Copy link
Contributor

Update CHANGES.txt to better highlight the breaking change that came with the latest version

CHANGES.txt Outdated
@@ -11,4 +11,4 @@ v1.2.5, 2022-07-12 -- Block some more bot useragents
v1.2.6, 2022-07-13 -- Block one more useragent - "gh"
v1.2.7, 2022-07-15 -- Block more user agents - "Petalbot"
v1.3.0, 2023-02-20 -- Add rate limits
v1.4.0, 2-24-06-21 -- Migrate to Flask.Limiter for rate limits
v2.0.0, 2-24-06-21 -- Migrate to Flask.Limiter for rate limits. Breaking Change: 'app' must be passed to 'build_search_view' as the positon 1 argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.0 was released, so maybe keep it?

Also, there is a typo in the date year. And I guess the date is not true anymore?

@bartaz
Copy link
Member

bartaz commented Aug 2, 2024

Maybe worth adding something to README as well?

In "Usage": "Changes in 2.0.0: In version 2.0 the app parameter is now required in build_search_view call", or something like that. To make it easier to notice.

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@petesfrench petesfrench merged commit c057377 into main Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants