Skip to content

Commit

Permalink
fix: include libffi-dev in charm part build-packages (#2043)
Browse files Browse the repository at this point in the history
This isn't needed for Red Hat based distributions as python3-devel
includes the necessary packages

Fixes #2023
CRAFT-3788
  • Loading branch information
lengau authored Dec 17, 2024
1 parent 0db15c1 commit 47fb62f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions charmcraft/parts/plugins/_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ def get_build_packages(self) -> set[str]:
"python3-setuptools",
"python3-venv",
"python3-wheel",
"libffi-dev",
"libyaml-dev",
}
elif platform.is_yum_based():
Expand Down
1 change: 1 addition & 0 deletions tests/unit/parts/plugins/test_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def test_charmplugin_get_build_package_deb_based(charm_plugin):
"python3-wheel",
"python3-venv",
"python3-dev",
"libffi-dev",
"libyaml-dev",
}

Expand Down

0 comments on commit 47fb62f

Please sign in to comment.