Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 and pydocstyle template tests with ruff #1461

Closed
lengau opened this issue Jan 3, 2024 · 0 comments · Fixed by #1941
Closed

Replace flake8 and pydocstyle template tests with ruff #1461

lengau opened this issue Jan 3, 2024 · 0 comments · Fixed by #1941
Labels
Enhancement New feature or request

Comments

@lengau
Copy link
Collaborator

lengau commented Jan 3, 2024

What needs to get done

We currently have tests that run each profile for charmcraft init and then run them through pydocstyle etc.

Replace these with tests that run ruff on them the way the linter says to do so.

Why it needs to get done

We moved everything to ruff but forgot these tests. It could become an issue if the tools diverge.

@lengau lengau added the Enhancement New feature or request label Jan 3, 2024
lengau added a commit that referenced this issue Oct 7, 2024
Fixes #1461
lengau added a commit that referenced this issue Oct 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #1461
lengau added a commit that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant