feat(config): support type:secret in config.options
#1623
Conversation
|
cf. canonical/operator#1166 where this was raised in ops. |
|
I can't say that I know the charmcraft bits well enough to concretely give an approval, but thank you for putting this together. |
There was a problem hiding this comment.
Thanks for doing this! The code looks good, but I'm thinking about how (and whether) we want to do this in 2.x considering that 3.0 is around the corner and will include this from your other PR.
I'll sleep on this and talk with some folks, and if you, @jameinel or anyone else would like to weigh in on it I'm open to hearing from you. (User stories that include staying on the 2.x branch after 3.0 will be most convincing - in-progress release notes for 3.0 are here: https://docs.google.com/document/d/1CPo8-dwlBU3Nd1dXUaZ1Rdfo3jPXvrkZs-ulg-DS_e0/edit)
syu-w
changed the title
type:secret in config.optionstype:secret in config.options
|
We're doing a 2.6 release to fix #1640 , so I'm going to retarget this and include it in that release. Thanks again for your patience folks! |
The `config.options` section of `charmcraft.yaml` supports, from Juju 3.1, a type `secret` (this is currently missing from the documentation, but the Juju team are addressing that now). This adds support for that, so that Charmcraft 2.5 can be used to pack charms that make use of this functionality.
The
config.optionssection ofcharmcraft.yamlsupports, from Juju 3.1, a typesecret(this is currently missing from the documentation, but the Juju team are addressing that now).This adds support for that, so that Charmcraft 2.5 can be used to pack charms that make use of this functionality.