Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove experimental flag for flask-framework extension #1629

Merged
merged 3 commits into from
Apr 4, 2024
Merged

remove experimental flag for flask-framework extension #1629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82e695d
remove experimental flag
jdkandersson Apr 3, 2024
7bcfd0a
only mark flask framework extension as no longer experimental
jdkandersson Apr 3, 2024
e9d2401
Merge branch 'main' into stable-release
lengau Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charmcraft/extensions/gunicorn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,9 @@ class FlaskFramework(_GunicornBase):
"description": "Set the secure attribute in the Flask application cookies. This configuration will set the FLASK_SESSION_COOKIE_SECURE environment variable. Run `app.config.from_prefixed_env()` in your Flask application in order to receive this configuration.",
},
}

@staticmethod
@override
def is_experimental(base: tuple[str, ...] | None) -> bool: # noqa: ARG004
"""Check if the extension is in an experimental state."""
return False
2 changes: 1 addition & 1 deletion charmcraft/templates/init-flask-framework/requirements.txt.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
paas-app-charmer~=0.2.1
paas-app-charmer==1.*
3 changes: 1 addition & 2 deletions tests/extensions/test_gunicorn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@


@pytest.fixture(name="flask_input_yaml")
def flask_input_yaml_fixture(monkeypatch, tmp_path):
monkeypatch.setenv("CHARMCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS", "1")
def flask_input_yaml_fixture(tmp_path):
return {
"type": "charm",
"name": "test-flask",
Expand Down
3 changes: 0 additions & 3 deletions tests/spread/commands/init-flask-framework/task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
summary: test charmcraft init with flask-framework profile

environment:
CHARMCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS: "true"

execute: |
unset CHARMCRAFT_STORE_API_URL
unset CHARMCRAFT_UPLOAD_URL
Expand Down
Loading