Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate devel bases with craft-application #1634

Closed
wants to merge 6 commits into from
Closed

feat: validate devel bases with craft-application #1634

wants to merge 6 commits into from

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Apr 9, 2024

@mr-cal
feat: validate devel bases with craft-application
8528ec3 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
build(deps): use craft-application test branch
b13956f 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal marked this pull request as draft April 9, 2024 18:25
@mr-cal mr-cal mentioned this pull request Apr 9, 2024
Merged
3 tasks
@mr-cal mr-cal changed the title [DRAFT] feat: validate devel bases with craft-application feat: validate devel bases with craft-application Apr 12, 2024
@mr-cal mr-cal marked this pull request as ready for review April 12, 2024 13:50
lengau
lengau reviewed Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great demo of how apps would use the craft-application feature, thanks!

@mr-cal
fix: update _providers_base()
d1c8239 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Contributor Author

mr-cal commented Apr 17, 2024

This is a great demo of how apps would use the craft-application feature, thanks!

Free charmcraft development!

Snapcraft, rockcraft, and charmcraft all define bases differently, I would have botched the craft-application code had I not tested it everywhere.

@mr-cal
Copy link
Contributor Author

mr-cal commented Apr 18, 2024

This PR will need to land after the next craft-application release.

I'm leaving this open and marked as a DRAFT to prevent accidental merges.

@mr-cal mr-cal marked this pull request as draft April 18, 2024 19:35
@mr-cal mr-cal closed this Jun 4, 2024
@mr-cal
Copy link
Contributor Author

mr-cal commented Jun 4, 2024

For now, this PR does not have to land due to changes in the craft-application.

That may change once canonical/craft-application#348 is fixed.

@mr-cal mr-cal deleted the work/CRAFT-2675-base-validation branch June 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-cal @lengau