Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning deprecated prime use #1642

Merged
merged 4 commits into from
Apr 12, 2024
Merged

fix: warning deprecated prime use #1642

merged 4 commits into from
Apr 12, 2024

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Apr 11, 2024 •
edited
Loading

Fixes: #1609

@syu-w syu-w requested review from lengau and mr-cal April 11, 2024 19:42
mr-cal
mr-cal approved these changes Apr 12, 2024
View reviewed changes
charmcraft/application/main.py Outdated Show resolved Hide resolved
lengau
lengau approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@lengau lengau merged commit 207a917 into main Apr 12, 2024
13 of 14 checks passed
@lengau lengau deleted the CRAFT-2618-prime-in-charm-warn branch April 12, 2024 16:10
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charmcraft 3.0.0 renders .charm files missing dispatch script and any meaningful python
3 participants
@syu-w @lengau @mr-cal