feat: add test command and templates #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatsuoka
force-pushed
the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
4 times, most recently
from
f07efab to
c6df503
Compare
The `charmcraft test` command invokes spread to run test suites on local and remote machines. A pre-defined spread configuration and multipass back-end are supplied. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
from
c6df503 to
eb6213a
Compare
|
Rebased on main. |
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
from
eb6213a to
cfda0e4
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
from
7efba0b to
0d5c2a0
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
from
0d5c2a0 to
6b1bb65
Compare
lengau
reviewed
Apr 23, 2024
| # arguments. We should implement better support for this case | ||
| # in craft-application. | ||
| idx = sys.argv.index("test") + 1 | ||
| sys.argv = [*sys.argv[:idx], "--", *sys.argv[idx:]] |
There was a problem hiding this comment.
This is still going to be a little bit weird because charmcraft test will take arguments like -shell rather than --shell. Can you think of a downside of stripping -- off the start of test parameters and replacing it with -?
There was a problem hiding this comment.
The -- separator is actually parsed by argparse to make it ignore any argument after that (so we can pass it directly to spread). The - vs -- inconsistency is an issue however, we can discuss that further and maybe go back to using -- as an explicit separator.
There was a problem hiding this comment.
Yeah, especially with the way this obscures the help text. I think long-term we'll probably need to make our own items for common parameters and then let the user pass -- <spread-params> if they want to do anything fancy with spread.
mr-cal
reviewed
Apr 24, 2024
charmcraft/templates/init-simple/tests/spread/lib/tools/retry.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Also don't run the github back-end locally. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
…r-charmcraft-test
mr-cal
approved these changes
Apr 30, 2024
lengau
approved these changes
May 8, 2024
lengau
deleted the
CRAFT-2707-Write-k8s-charm-test-templates-for-charmcraft-test
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
charmcraft testcommand invokes spread to run test suites onlocal and remote machines. A pre-defined spread configuration and
multipass back-end are supplied.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com