Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused fetch-lib command #1663

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Apr 22, 2024

This removes the unused pre-craft-application fetch-lib command.

This removes the unused pre-craft-application `fetch-lib` command.
@lengau lengau changed the title refactor: remove unusued fetch-lib command refactor: remove unused fetch-lib command Apr 22, 2024
@lengau lengau marked this pull request as ready for review April 23, 2024 17:05
@lengau lengau requested review from tigarmo, mr-cal and mattculler April 23, 2024 17:05
@lengau lengau merged commit b3d35e6 into main Apr 24, 2024
14 checks passed
@lengau lengau deleted the CRAFT-2283/remove-old-fetch-lib-cmd branch April 24, 2024 15:59
@maurorodrigues
Copy link

hey @lengau, I'm no charm expert, but I've been using fetch-lib. Is there an alternative to fetch-lib? Maybe something automatically done within the charmcraft process?

@lengau
Copy link
Collaborator Author

lengau commented May 22, 2024

@maurorodrigues this only applies to an implementation that's no longer used, not to the command itself.

We're moving towards defining the libraries in charmcraft.yaml and using the newer fetch-libs command with that, but we currently have no plans to remove fetch-lib as a charmcraft command available to those who need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants