Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fetch-libs command #1665

Merged
merged 14 commits into from
Apr 25, 2024
Merged

feat: add fetch-libs command #1665

merged 14 commits into from
Apr 25, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Apr 24, 2024

No description provided.

@lengau lengau requested review from mr-cal and tigarmo April 24, 2024 17:40
tigarmo
tigarmo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approved but please take a look at the added coverage/test xmls

charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
results/coverage-test-py3.12.xml Outdated Show resolved Hide resolved
mr-cal
mr-cal approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

charmcraft/application/commands/store.py Show resolved Hide resolved
@lengau lengau requested review from mr-cal and tigarmo April 24, 2024 19:09
mr-cal
mr-cal approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

charmcraft/application/commands/store.py Show resolved Hide resolved
@lengau lengau merged commit 38ea17d into main Apr 25, 2024
14 checks passed
@lengau lengau deleted the CRAFT-2283/fetch-libs branch April 25, 2024 15:34
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @tigarmo @mr-cal