Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only keep metadata.yaml for reactive charms #1666

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Apr 24, 2024

Fixes #1654

@lengau lengau force-pushed the CRAFT-2816/gh-1654 branch from d6b3df6 to e07562c Compare April 24, 2024 18:16
@lengau lengau changed the title fix: only keep metadata.yaml for reactive plugins fix: only keep metadata.yaml for reactive charms Apr 24, 2024
@lengau lengau marked this pull request as ready for review April 24, 2024 21:03
@lengau lengau requested review from tigarmo, mr-cal and mattculler April 24, 2024 21:04
charmcraft/services/package.py Outdated Show resolved Hide resolved
@lengau lengau merged commit b2b127e into main Apr 26, 2024
14 checks passed
@lengau lengau deleted the CRAFT-2816/gh-1654 branch April 26, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have to run charmcraft clean after adding a new integration
3 participants