Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload OCI image resources with skopeo #1696

Merged
merged 19 commits into from
Jun 12, 2024
Merged

feat: upload OCI image resources with skopeo #1696

merged 19 commits into from
Jun 12, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jun 7, 2024

Fixes #1684, partial for #1685

@lengau lengau force-pushed the work/CRAFT-2921 branch 5 times, most recently from 4741e11 to c110cee Compare June 10, 2024 17:32
@lengau lengau force-pushed the work/CRAFT-2921 branch from c110cee to 258c538 Compare June 10, 2024 17:35
@lengau lengau force-pushed the work/CRAFT-2921 branch 8 times, most recently from 315461c to 8fa3785 Compare June 10, 2024 22:02
@lengau lengau force-pushed the work/CRAFT-2921 branch from 8fa3785 to d2cada3 Compare June 10, 2024 22:10
@lengau lengau requested review from mr-cal and tigarmo June 10, 2024 22:16
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

.github/workflows/tests.yaml Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/errors.py Show resolved Hide resolved
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

charmcraft/services/image.py Show resolved Hide resolved
charmcraft/services/image.py Outdated Show resolved Hide resolved
@lengau lengau enabled auto-merge June 11, 2024 19:39
@lengau lengau force-pushed the work/CRAFT-2921 branch from 07fdc6a to 5891bfb Compare June 11, 2024 19:42
@lengau lengau disabled auto-merge June 12, 2024 13:47
@lengau lengau enabled auto-merge June 12, 2024 13:47
@lengau lengau force-pushed the work/CRAFT-2921 branch from be731f9 to 22a7cf4 Compare June 12, 2024 15:58
@lengau lengau force-pushed the work/CRAFT-2921 branch from c865ce3 to f04b868 Compare June 12, 2024 18:47
@lengau lengau disabled auto-merge June 12, 2024 19:18
@lengau lengau merged commit fb8680e into main Jun 12, 2024
14 of 16 checks passed
@lengau lengau deleted the work/CRAFT-2921 branch June 12, 2024 19:18
lengau added a commit that referenced this pull request Jun 13, 2024
Copies the Skopeo class from:
#1696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Charmcraft to upload a rock directly from the file or directly between registries
3 participants