Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three changes #1731

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Three changes #1731

merged 4 commits into from
Jul 16, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jul 16, 2024 •
edited
Loading

  • build(deps): update craft-providers
  • chore: mark noble as stable
  • fix(tests): correctly run noble tests

Store test failure is due to #1712

@lengau lengau marked this pull request as ready for review July 16, 2024 16:54
@lengau lengau changed the title build(deps): update craft-providers Three changes Jul 16, 2024
dariuszd21
dariuszd21 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lengau lengau merged commit 13ca763 into main Jul 16, 2024
16 of 17 checks passed
@lengau lengau deleted the build/craft-providers branch July 16, 2024 17:24
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

@mattculler mattculler Awaiting requested review from mattculler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @dariuszd21 @mr-cal