Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): allow long summaries in output #1759

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(metadata): allow long summaries in output #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charmcraft/models/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class CharmMetadata(models.BaseMetadata):

name: models.ProjectName
display_name: models.ProjectTitle | None = None
summary: models.SummaryStr
summary: pydantic.StrictStr
description: pydantic.StrictStr
maintainers: list[pydantic.StrictStr] | None = None
assumes: list[str | dict[str, list | dict]] | None = None
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/models/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

BASIC_CHARM_METADATA_DICT = {
"name": "test-charm",
"summary": "A charm for testing",
"summary": "A charm for testing, with a summary string that is more than seventy-eight characters long.",
"description": "A fake charm used for testing purposes.",
}
BASIC_CHARM_DICT = {
Expand Down
Loading