fix(strict-deps): fail if venv is inconsistent #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs `pip check` to ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not. Fixes #1781
lengau
force-pushed
the
work/1781/pip-check
branch
from
ab8179d to
ba92c13
Compare
This adds a test for when strict-dependencies is used and packages are missing from the requirements file.
mr-cal
approved these changes
Aug 5, 2024
tigarmo
approved these changes
Aug 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lengau
added a commit
that referenced
this pull request
Aug 6, 2024
This runs `pip check` to ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not. Fixes #1781
lengau
added a commit
that referenced
this pull request
Aug 6, 2024
This runs `pip check` to ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not. Fixes #1781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
pip checkto ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not.Fixes #1781