chore: merge pydantic 2 support to main #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildPlanner tests are still failing due to validation issues.
`build-for` now has to be a list, even with `all`. So `build-for: all` in yaml becomes `build-for: [all]`
The only thing that remained using this module was its set of tests.
Also removes the related unused test fixtures.
These are leftover from before the craft-application move, but were used for ensuring compatibility of the commands. Now that they're no longer needed, we can eliminate them.
craft-application provides this so this one is redundant
Also removes the now-unused `format` module.
Everything from this function now exists in the AnalysisService.
Instead there's just a charmhub_config fixture that provides access to the charmhub staging.
The plugin is now the first thing mentioned in a part.
Python 3.11 is the first version with `os.EX_OK`, but 3.12 is the version used on noble.
On Windows, set the minimum to Python 3.11 as python 3.10 doesn't have os.EX_OK
The pydantic 2 change caused some weirdness in adding default parts, so this fixes it. After this, pydantic 2 should be ready to merge to main.
lengau
force-pushed
the
work/pydantic-2/merge-main
branch
from
2a2751c to
3ad4988
Compare
mr-cal
approved these changes
Aug 15, 2024
lengau
force-pushed
the
work/pydantic-2/merge-main
branch
3 times, most recently
from
5725302 to
69c9aeb
Compare
dariuszd21
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything here has already been reviewed.