Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renovate): ignore tox-gh updates #1847

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore(renovate): ignore tox-gh updates #1847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
// Each ignore is probably connected with an ignore in pyproject.toml.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this comment, did you need to also add an ignore in pyproject.toml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case no, because we don't even have tox-gh in pyproject.toml

// Ensure you change this and those simultaneously.
"urllib3",
// Temporary until we remove Windows. https://github.com/canonical/charmcraft/issues/1810
"windows", // We'll update Windows versions manually.
"tox-gh", // As of 1.3.2 tox-gh doesn't support Windows 2019's python 3.7.
],
labels: ["dependencies"], // For convenient searching in GitHub
baseBranches: ["$default", "/^hotfix\\/.*/"],
Expand Down
Loading