Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rabbitmq to init templates #1905

Merged

Conversation

javierdelapuente
Copy link
Contributor

@javierdelapuente javierdelapuente commented Sep 17, 2024

RabbitMQ is already in paas-app-charmer (see canonical/paas-app-charmer#39).

Add RabbitMQ requires to init templates (commented out) so it is easier for the user to be able to uncomment it if needed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@javierdelapuente javierdelapuente marked this pull request as ready for review September 17, 2024 09:54
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for also putting this in #1868 so we don't have to update that.

@lengau lengau requested a review from tigarmo September 17, 2024 13:23
@lengau lengau enabled auto-merge September 17, 2024 13:23
@lengau lengau requested a review from a team September 17, 2024 17:04
@lengau lengau added this pull request to the merge queue Sep 18, 2024
Merged via the queue into canonical:main with commit c11748f Sep 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants