Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the newer ops.testing classes for the charm unit tests #1933

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Updates the simple, machine, and kubernetes profiles to use the ops.testing state transition classes (previously: Scenario) rather than the legacy Harness API.

The content of what each set of tests is testing remains unchanged, it's just using the new API to do the tests.

ops[testing] is installed via the tox dependencies (but should likely be in an optional dependencies group in the future, once CC005 is finalised). I've included it in the static dependencies as well, because as the charm gains additional tests those should also be statically checked and that will require the ops[testing] classes.

Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@lengau lengau requested a review from a team October 8, 2024 12:16
@lengau lengau enabled auto-merge October 8, 2024 12:16
@lengau lengau added this pull request to the merge queue Oct 9, 2024
Merged via the queue into canonical:main with commit f9d17b0 Oct 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants