Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make charmcraft work with snap parallel installs #1950

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix: make charmcraft work with snap parallel installs #1950

merged 3 commits into from
Oct 15, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Oct 8, 2024

Fixes #1770

@lengau lengau added the rebase label Oct 8, 2024
@lengau lengau force-pushed the work/1770/CRAFT-3351/update branch from 5c6afd4 to 81678b0 Compare October 8, 2024 21:30
@lengau lengau requested a review from mr-cal October 8, 2024 23:13
mr-cal
mr-cal approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@lengau lengau marked this pull request as ready for review October 11, 2024 17:58
@lengau lengau requested a review from a team October 11, 2024 17:58
@lengau lengau added this pull request to the merge queue Oct 15, 2024
@lengau lengau removed this pull request from the merge queue due to a manual request Oct 15, 2024
@lengau lengau merged commit 2399ddf into main Oct 15, 2024
23 checks passed
@lengau lengau deleted the work/1770/CRAFT-3351/update branch October 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

charmcraft snap doesn't work with snap parallel installs
3 participants
@lengau @mr-cal @mattculler