Check charmcraft.yaml for charm name
#1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielArndt
force-pushed
the
1973-check-charmcraft-yaml
branch
from
9d091f7 to
44b1503
Compare
lengau
approved these changes
Nov 18, 2024
mr-cal
approved these changes
Nov 19, 2024
DanielArndt
force-pushed
the
1973-check-charmcraft-yaml
branch
from
d5ed695 to
c13acc8
Compare
|
Force pushed to remove the merge commits, as they defaulted to my personal e-mail which wasn't passing the CLA. Hopefully this fixes it. |
|
@lengau I don't think these status checks are related to my PR. Any way I can help move this forward or do those need to be fixed first? |
lengau
pushed a commit
to tmihoc/charmcraft
that referenced
this pull request
Dec 19, 2024
I don't know if this is the best way to solve the problem, but it's an attempt to solve canonical#1973 Tested locally and it seems to solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the best way to solve the problem, but it's an attempt to solve #1973
Tested locally and it seems to solve the problem.