Migrate Flask tutorial to Charmcraft RTD #1976
Conversation
added a few commands taken from the rockcraft task.yaml
skipped over the parts where code files were changed (for now)
24.04 blueprint
Move setup text to its own file Fix some linting issues
migrate.py visitors_app.py
So that the spread test won't pick it up too early in the test (causing a blocked status in the flask-hello-world app)
|
|
||
| .. code-block:: bash | ||
| sudo snap install charmcraft --channel latest/edge --classic |
There was a problem hiding this comment.
Should we use latest/edge here or switch to stable? Rockcraft above is using stable
There was a problem hiding this comment.
Does the stable version of charmcraft support all the extensions? For Flask it does, but since this is under reuse I wanted to make sure the setup was as extension-agnostic as possible
There was a problem hiding this comment.
oh right, hmm. For some we should use edge, for others stable. Perhaps we can have edge and stable setup reuable setup instructions?
| # [docs:deploy-juju-model-end] | ||
|
|
||
| # [docs:deploy-nginx] | ||
| juju deploy nginx-ingress-integrator --channel=latest/edge --revision 122 |
There was a problem hiding this comment.
Any particular reason for pinning the revision please? I think lates/edge should get the latest revision
There was a problem hiding this comment.
latest/edge did not get the latest revision in the GitHub CI test -- it did for my local testing though.
In GitHub, latest/edge grabbed revision 44 (suspiciously, this is the latest revision for the Ubuntu 22.04 base while 122 is the latest revision for the Ubuntu 20.04 base) and revision 44 ran into hook failed: "config-changed" errors upon deployment
One other thing to note: When I specified the base instead of revision, the "hook failed" issues went away.
There was a problem hiding this comment.
I think that is an issue with the charm, I don't know why we are running it on 20.04. Let's leave it for now and I'll see whats going on
docs/tutorial/flask.rst
Outdated
There was a problem hiding this comment.
When I go to the readthedocs for this PR (you can do that by clicking as indicated in the screenshot on the PR page), I can't see the tutorial being rendered? It is usually better to review it there to check for that the correct lines were included etc
There was a problem hiding this comment.
I see the tutorial being rendered, but there isn't a dedicated tutorial section. I can reorganise
There was a problem hiding this comment.
I added a tutorial section, and the Flask tutorial shows up underneath it when I check the rendered page. Let me know if you don't see it
|
Thanks for doing this, I know it isn't easy especially because this involved code 🙂 |
The current Flask tutorial: https://juju.is/docs/sdk/write-your-first-kubernetes-charm-for-a-flask-app
This PR will move the tutorial off of Discourse and Charm SDK and onto the Charmcraft RTD.