Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish-lib): exit with status 1 on error #2042

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix(publish-lib): exit with status 1 on error #2042

merged 2 commits into from
Dec 17, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Dec 16, 2024

Fixes #1981

CRAFT-3830

@lengau lengau marked this pull request as ready for review December 16, 2024 17:14
@lengau lengau requested review from mattculler and bepri December 16, 2024 17:15
@lengau lengau enabled auto-merge December 17, 2024 21:20
@lengau lengau disabled auto-merge December 17, 2024 22:54
@lengau lengau merged commit f328234 into main Dec 17, 2024
27 of 28 checks passed
@lengau lengau deleted the work/1981/CRAFT-3830 branch December 17, 2024 22:54
lengau added a commit to tmihoc/charmcraft that referenced this pull request Dec 19, 2024
@lengau
fix(publish-lib): exit with status 1 on error (canonical#2042)
2cf3c7b 
Fixes canonical#1981

CRAFT-3830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@bepri bepri bepri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

charmcraft publish-lib exits with 0 even if publishing fails
3 participants
@lengau @bepri @mattculler