-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes page and release notes for 3.4 specifically. #2115
Conversation
This just adds the template from starbase
ed271c4
to
382e5fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple more instances of "Starcraft" in the templates, up to you if you want to fix those.
27e23ab
to
9f7d415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing a period here still I think :)
This has the bonus effect of fixing a duplicate ref error.
Disable the lint check for underscores after links (`text<link>`_) so that it doesn't give us grief over literalrefs. This is compensating for our own extension, not sphinx-lint itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lengau This is very good work! I like what you've put together here.
I've made many minor tweaks here and there for language, and fixed the build errors.
I take it we're not moving the changelog because of how many links it would break. It makes sense to me to make that move dependent on the future redirect extension.
@medubelko thanks for your updates! Indeed I am waiting for us to have a redirector before I move the changelog. I've made one change to the snapd references and we should be ready to go, but I'd prefer if we can solve the "related issue" stuff today. |
Smooth out some of the language as a bonus.
Done in steps as 3 separate commits, but really one logical addition.
CRAFT-3996