build: inform user that packing charm may take time (CRAFT-347) #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjp256
changed the title
Let the user know which charm is being packed and that it may take some time. Move launched_environment() logic into pack_charm_in_instance() to have the information required (charm name) prior to launching. Example output: ``` $ charmcraft pack Packing charm 'foo_ubuntu-18.04-amd64.charm' which may take several minutes... Created 'foo_ubuntu-18.04-amd64.charm'. Packing charm 'foo_ubuntu-20.04-amd64.charm' which may take several minutes... Created 'foo_ubuntu-20.04-amd64.charm'. ``` Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
reviewed
Jul 2, 2021
charmcraft/commands/build.py
Outdated
| raise CommandError( | ||
| f"Failed to build charm for bases index '{bases_index}'." | ||
| ) from error | ||
| logger.info(f"Packing charm {charm_name!r} which may take several minutes...") |
There was a problem hiding this comment.
Mentioning minutes gives me a Windows 95 progress bar vibe, won't age well
Suggested change
| logger.info(f"Packing charm {charm_name!r} which may take several minutes...") | |
| logger.info(f"Packing charm {charm_name!r}...") |
There was a problem hiding this comment.
Haha, well I expect it to be redone in a month or so with @facundos new messages / status handling. Will update.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the user know which charm is being packed and that it may take some
time. Move launched_environment() logic into pack_charm_in_instance()
to have the information required (charm name) prior to launching.
Example output:
Signed-off-by: Chris Patterson chris.patterson@canonical.com