[DPE-4779] Add Kraft test #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
reviewed
Jul 5, 2024
|
|
||
| - name: Check topic creation | ||
| run: | | ||
| topic_creation=$(charmed-kafka.topics --create --topic test --bootstrap-server localhost:9092) |
There was a problem hiding this comment.
question I would have thought that we need sudo here too
There was a problem hiding this comment.
Apparently not. I copied the previous test with zookeeper, where is not needed. Didn't investigate on why though.
deusebio
approved these changes
Jul 5, 2024
marcoppenheimer
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Kraft test to the snap.
storagebinary entrypoint fixed