This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Refactor cpufreq tests with unit tests #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patliuu
requested review from
baconYao,
zongminl,
LiaoU3,
rickwu666666 and
stanley31huang
baconYao
suggested changes
Jan 11, 2024
| - subprocess.CalledProcessError: If the 'modprobe' command encounters an | ||
| error during the module loading process. | ||
| """ | ||
| logging.info( |
There was a problem hiding this comment.
I suddenly have an idea is about adjusting the level from info to be warning
Reason:
- It alerts tester to notice this symptom.
- File an issue (Severity: High) to confirm with Customer to check whether this module is probed by default or not.
| return exit_code | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
The policy from Cert Team
- The if name == "main": is abused, should only call main
Reference: canonical/checkbox#586 (review)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sideload results:
https://pastebin.canonical.com/p/QmS5KKB2tF/
https://pastebin.canonical.com/p/bB7jBwGTMp/