Fix some issues related with the test case power-management/lid_close_suspend_open (Bugfix)

[eugene-yujinwu]

Fix some issues related with the test case power-management/lid_close_suspend_open (bugfix) (#1080)

• Include a note to ensure the test is executed at the appropriate time
• Fix the typo in the test order number
• Remove functionally similar test cases power-management/lid from the test plan
• Adjust the place of test case to avoid running it just after the suspend case

Description

Resolved issues

Documentation

Tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.48%. Comparing base (8a9c908) to head (f1f03f9).
Report is 10 commits behind head on main.

❗ Current head f1f03f9 differs from pull request most recent head 90ccfd7

Please upload reports for the commit 90ccfd7 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   44.17%   41.48%   -2.70%     
==========================================
  Files         359      341      -18     
  Lines       38812    37754    -1058     
  Branches     6581     6412     -169     
==========================================
- Hits        17147    15661    -1486     
- Misses      21003    21451     +448     
+ Partials      662      642      -20     

Flag	Coverage Δ
provider-base	15.26% <ø> (-3.30%)	⬇️
provider-genio	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stanley31huang]

@eugene-yujinwu please remove the latest white space character from the title for the validate_title check.

[eugene-yujinwu]

@eugene-yujinwu please remove the latest white space character from the title for the validate_title check.

Done. Thanks!

[clairlin53]

@eugene-yujinwu
I recommend keeping the second times with lid test, there were some issues observed with lid close after second times and there is an issue when closing the lid over 10 seconds, please refer to the following bugs for more details.
https://bugs.launchpad.net/stella/+bug/1974120
https://bugs.launchpad.net/stella/+bug/1979038
https://bugs.launchpad.net/stella/+bug/1962826

[eugene-yujinwu]

@eugene-yujinwu I recommend keeping the second times with lid test, there were some issues observed with lid close after second times and there is an issue when closing the lid over 10 seconds, please refer to the following bugs for more details. https://bugs.launchpad.net/stella/+bug/1974120 https://bugs.launchpad.net/stella/+bug/1979038 https://bugs.launchpad.net/stella/+bug/1962826

@clairlin53 Thank you for your comment. I think it makes sense to keep this case, as shown by the bugs you mentioned , we have indeed encountered situations in the past where the first close lid worked fine, but the second close lid had a problem.
I will add it back. Thank you.

[eugene-yujinwu]

Add the power-management/lid test back per Clair's comments.

[eugene-yujinwu]

Reopen it. Thank @vincent!

[hanhsuan]

@eugene-yujinwu I am thinking about that the 30 seconds is the default value defined in the logind.conf by HoldoffTimeoutSec. Is that possible to show the real value while this test case at beginning ? Then the user don't have to guess how long they have to wait for next test.

[stanley31huang]

@eugene-yujinwu please change the status of this PR to Ready for review when you think it's ready. And please make sure all unit tests passed with your changes.

[eugene-yujinwu]

@stanley31huang just rebase the commit and reopen the review. But I cannot figure out why some of the unit tests failed. Do you have any idea or hints? Thanks!

[eugene-yujinwu]

@stanley31huang , finally I make the unit tests passed:). could you kindly review this, thanks!

[pieqq]

Nice quality of life improvement on this job!

I feel like the Shell script is becoming really big and hard to maintain, and it is not tested... I think it would be worthwhile to convert it into a Python script with unit tests.

That said, I've made a few comments and added some suggestions.

[eugene-yujinwu]

@pieqq Thanks for review. A new commit was pushed per your suggestion. Could you kindly review it. Thanks!

[eugene-yujinwu]

Nice quality of life improvement on this job!

I feel like the Shell script is becoming really big and hard to maintain, and it is not tested... I think it would be worthwhile to convert it into a Python script with unit tests.

That said, I've made a few comments and added some suggestions.

@pieqq Do you think I should drop this PR, and rewrite it with python and submit a new PR?

[pieqq]

+1, thanks!

[pieqq]

Nice quality of life improvement on this job!
I feel like the Shell script is becoming really big and hard to maintain, and it is not tested... I think it would be worthwhile to convert it into a Python script with unit tests.
That said, I've made a few comments and added some suggestions.

@pieqq Do you think I should drop this PR, and rewrite it with python and submit a new PR?

Let'd land this. You can keep a note to improve it later (switch to Python + add unit tests).

[eugene-yujinwu]

Nice quality of life improvement on this job!
I feel like the Shell script is becoming really big and hard to maintain, and it is not tested... I think it would be worthwhile to convert it into a Python script with unit tests.
That said, I've made a few comments and added some suggestions.

@pieqq Do you think I should drop this PR, and rewrite it with python and submit a new PR?

Let'd land this. You can keep a note to improve it later (switch to Python + add unit tests).

Thank you @pieqq . OK, let's do it later.