Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocker/non-blocker status added to a few tests (Bugfix) #1150

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

rodwsmith
Copy link
Collaborator

@rodwsmith rodwsmith commented Apr 5, 2024

BugFix: Add explicit blocker/non-blocker status to a few tests

Description

Jeff wanted these set explicitly, so this merge does so.

Resolved issues

https://warthogs.atlassian.net/browse/SERVCERT-1514

Documentation

These changes should be picked up automatically by scripts/generate_test_guide.py in the certification-docs project, once merged.

Tests

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.05%. Comparing base (4c58a14) to head (5748658).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   43.05%   43.05%           
=======================================
  Files         355      355           
  Lines       38575    38575           
  Branches     6549     6549           
=======================================
  Hits        16607    16607           
  Misses      21302    21302           
  Partials      666      666           
Flag Coverage Δ
provider-base 15.94% <ø> (ø)
provider-certification-server 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodwsmith rodwsmith changed the title Add: blocker/non-blocker status to a few tests BugFix: blocker/non-blocker status to a few tests Apr 5, 2024
@rodwsmith rodwsmith changed the title BugFix: blocker/non-blocker status to a few tests BugFix: blocker/non-blocker status to a few tests Bugfix Apr 5, 2024
@rodwsmith rodwsmith changed the title BugFix: blocker/non-blocker status to a few tests Bugfix blocker/non-blocker status added to a few tests (Bugfix) Apr 5, 2024
@Hook25 Hook25 merged commit b6154f6 into main Apr 8, 2024
15 of 19 checks passed
@Hook25 Hook25 deleted the update-server-cert-test-cases branch April 8, 2024 07:21
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Apr 17, 2024
)

Add: blocker/non-blocker status to a few tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants