remove the unused [comment] section from config file (bugfix) #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parently not used and has been forgotten about for quite some time. #1149
bladernr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=======================================
Coverage 43.09% 43.09%
=======================================
Files 355 355
Lines 38602 38602
Branches 6556 6556
=======================================
Hits 16634 16634
Misses 21302 21302
Partials 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bladernr
changed the title
bladernr
changed the title
Hook25
deleted the
1149-checkbox-complains-about-the-common-section-in-canonical-certificationconf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as it is apparently not used and has been forgotten about for quite some time. #1149
Description
Just removes the old unused [comment] section from the config file for the server cert tools.
Resolved issues
#1149
Documentation
Deletion of something everyone had forgotten, no docs changes needed.
Tests
Removed the section, ran a launcher, saw no warnings about the section.