-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[checkbox-ce-oem] Add GPIO slot test for gadget SNAP (New) #1174
Conversation
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
d55effe
to
567713f
Compare
567713f
to
1aff355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my suggestions.
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/units/gpio/jobs.pxu
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/units/gpio/jobs.pxu
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
9ada3cc
to
7a70fde
Compare
@LiaoU3 Fixed and thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline change
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/check_gpio.py
Outdated
Show resolved
Hide resolved
Those GPIO related jobs intend to test if GPIO ports are exported after connecting interfaces between checkbox and gadget snap
7a70fde
to
1f17ea0
Compare
Hi @baconYao, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline comment
…o.py Co-authored-by: Pei Yao-Chang <baconYao@users.noreply.github.com>
b05bd06
to
89b6fcd
Compare
@baconYao Fixed. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Those GPIO related jobs intend to test if GPIO ports are exported after connecting interfaces between checkbox and gadget snap
Description
We have some projects that defined GPIO slots in the gadget SNAP. We intend to test if GPIO ports are exported after connecting interfaces between the checkbox and gadget snap.
This test requires the change on checkbox-support. #1179
Resolved issues
Documentation
Tests
Test result pass:
https://certification.canonical.com/hardware/202401-33430/submission/364099/test-results/pass/
Test result fail:
https://certification.canonical.com/hardware/202401-33430/submission/364099/test-results/fail/