Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] Add GPIO slot test for gadget SNAP (New) #1174

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

rickwu666666
Copy link
Contributor

@rickwu666666 rickwu666666 commented Apr 11, 2024

Those GPIO related jobs intend to test if GPIO ports are exported after connecting interfaces between checkbox and gadget snap

Description

We have some projects that defined GPIO slots in the gadget SNAP. We intend to test if GPIO ports are exported after connecting interfaces between the checkbox and gadget snap.
This test requires the change on checkbox-support. #1179

Resolved issues

Documentation

Tests

Test result pass:
https://certification.canonical.com/hardware/202401-33430/submission/364099/test-results/pass/

Test result fail:
https://certification.canonical.com/hardware/202401-33430/submission/364099/test-results/fail/

@rickwu666666 rickwu666666 marked this pull request as draft April 12, 2024 00:51
@rickwu666666 rickwu666666 marked this pull request as ready for review April 15, 2024 01:07
@rickwu666666 rickwu666666 force-pushed the add-gpio-slots-test branch 2 times, most recently from d55effe to 567713f Compare April 15, 2024 04:15
@rickwu666666 rickwu666666 marked this pull request as draft April 15, 2024 04:21
@rickwu666666 rickwu666666 marked this pull request as ready for review April 15, 2024 07:56
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions.

@rickwu666666 rickwu666666 force-pushed the add-gpio-slots-test branch 2 times, most recently from 9ada3cc to 7a70fde Compare April 16, 2024 05:46
@rickwu666666
Copy link
Contributor Author

Please see my suggestions.

@LiaoU3 Fixed and thanks for the review.

LiaoU3
LiaoU3 previously approved these changes Apr 16, 2024
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline change

@rickwu666666
Copy link
Contributor Author

Please see my inline change

Hi @baconYao,
Thanks for the review. I've pushed the fix.

Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comment

…o.py

Co-authored-by: Pei Yao-Chang <baconYao@users.noreply.github.com>
@rickwu666666
Copy link
Contributor Author

Please see my inline comment

@baconYao Fixed. Thanks.

Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickwu666666 rickwu666666 merged commit 26a3d61 into main Apr 24, 2024
5 checks passed
@rickwu666666 rickwu666666 deleted the add-gpio-slots-test branch April 24, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants