Fixed bug when missing one item in the status and added debug info (BugFix) #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhsuan
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Tested result as below:
Matched: https://certification.canonical.com/hardware/202001-27667/submission/363883/
Not matched: https://certification.canonical.com/hardware/202001-27667/submission/363884/
Not matched-r: https://certification.canonical.com/hardware/202001-27667/submission/363885/
Looks great. Thanks for your help.
fernando79513
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 43.19% 43.20%
=======================================
Files 356 356
Lines 38653 38659 +6
Branches 6561 6560 -1
=======================================
+ Hits 16697 16701 +4
Misses 21293 21293
- Partials 663 665 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Apr 17, 2024
…ugFix) (canonical#1178) * Fixed bug when missing one item in the status and added debug info. * Formatted pipewire utils tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug on the comparison test. When one item was missing on the second status, the test was passing anyway. The test could fail when running
suspend/audio_after_suspendWe have fix this behavior and added some debug info in case the test fails, according to this comment
Resolved issues
N/A
Documentation
N/A
Tests