Make networking/http test more resilient (bugfix) #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job often fails, usually because of connectivity issues. It is now replaced with a Python script that automatically runs the `wget` command 3 times, increasing the timeout after each failure to give more chances to connect succesfully. Fix CHECKBOX-1419
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 43.32% 43.36% +0.03%
==========================================
Files 356 357 +1
Lines 38658 38684 +26
Branches 6559 6560 +1
==========================================
+ Hits 16750 16776 +26
Misses 21245 21245
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Following feedback from team, reworking the connection function to use a random delay, using a backoff and a jitter. Each new attempt will wait longer than the previous one (up to 60 seconds per attempt). The jitter is here to prevent the test from choking the infrastructure if many devices are trying to run this test at the same moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This job often fails, usually because of connectivity issues.
It is now replaced with a Python script that automatically runs the
wgetcommand 5 times, adding backoff+jitter after each attempt to prevent the test server to misbehave in case too many devices would run this test at the same time.Resolved issues
Fixes https://warthogs.atlassian.net/browse/CHECKBOX-1419
Documentation
Tests
main(in the test below, I run checkbox while disconnected from the Internet, and I connect to a WiFi after a few seconds):