Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modprobe_attachment and sysctl_attachment failed in remote mode (BugFix) #1214

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

eugene-yujinwu
Copy link
Contributor

@eugene-yujinwu eugene-yujinwu commented Apr 29, 2024

Uploading test-result.zip…
When run the information attachment job in remote mode, the sysctl_attachment and modprobe_attachment always failed. If I run it with the root user, the job will be passed without problem.

Description

The sysctl_attachment and modprobe_attachment job will failed in remote mode.

Resolved issues

The sysctl_attachment and modprobe_attachment job will failed in remote mode.

Documentation

Tests

Attached the test report for which run the test before the fix in local/remote mode, after the fix in local/remote mode.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.32%. Comparing base (9318a5c) to head (4f84db1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   43.32%   43.32%           
=======================================
  Files         356      356           
  Lines       38658    38658           
  Branches     6559     6559           
=======================================
  Hits        16750    16750           
  Misses      21245    21245           
  Partials      663      663           
Flag Coverage Δ
provider-base 16.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, before merging this can you copy-paste here the error message so that we can see that this is a permission error? (the link in your report is broken for some reason)

@eugene-yujinwu
Copy link
Contributor Author

@eugene-yujinwu
Copy link
Contributor Author

eugene-yujinwu commented Apr 29, 2024

the error info before the fix:

Outcome: job passed
----------------------------[ Running job 28 / 29 ]-----------------------------
-------------------[ Attach the contents of /etc/modprobe.* ]-------------------
ID: com.canonical.certification::modprobe_attachment
Category: Informational tests

find: Failed to change directory: /tmp/cwd-qjd02l9n.8e97016a9495dccd7a89c0ff341c8acc36fe835ff7dc3d91f3fee9d957c60f89: Permission denied
find: Failed to restore initial working directory: /tmp/cwd-qjd02l9n.8e97016a9495dccd7a89c0ff341c8acc36fe835ff7dc3d91f3fee9d957c60f89: Permission denied

Outcome: job failed
----------------------------[ Running job 29 / 29 ]-----------------------------
---------------------[ Attach sysctl configuration files. ]---------------------
ID: com.canonical.certification::sysctl_attachment
Category: Informational tests

find: Failed to change directory: /tmp/cwd-rlvpsmgc.ffa0da6b1c683aed49f2375cb7c30c8e9519afacb0783a0fe124c411f32d134f: Permission denied
find: Failed to restore initial working directory: /tmp/cwd-rlvpsmgc.ffa0da6b1c683aed49f2375cb7c30c8e9519afacb0783a0fe124c411f32d134f: Permission denied

Outcome: job failed

@Hook25
Copy link
Collaborator

Hook25 commented Apr 29, 2024

We are having some problems with the uploads today, here are the outputs, the fix works:

(these are submissions.html -> pdf because GH doesn't like html files)

@Hook25 Hook25 merged commit 068f142 into main Apr 29, 2024
14 checks passed
@Hook25 Hook25 deleted the fix-sysfs-modprobe-attachment-fail branch April 29, 2024 10:07
@eugene-yujinwu
Copy link
Contributor Author

@Hook25 thank you for your quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants