Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added core24 to the list of the snaps that should be installed (BugFix) #1307

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fernando79513
Copy link
Collaborator

@fernando79513 fernando79513 commented Jun 24, 2024

Description

The snap-list test was failing on core24 because it was looking for a list of "core" snaps that did not included core24.
We have modified the script so it looks for any snap containing the "core" string.

http://10.102.156.15:8080/view/checkbox-edge-validation/job/checkbox-edge-validation-uc24-amd64/10/console

Resolved issues

N/A

Documentation

N/A

Tests

I run the snap-list test on core 24 and the test passes:
checkbox.checkbox-cli run com.canonical.certification::snappy/snap-list

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (dae49f5) to head (8cee398).
Report is 115 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files         359      359           
  Lines       38813    38813           
  Branches     6581     6581           
=======================================
  Hits        17148    17148           
  Misses      21003    21003           
  Partials      662      662           
Flag Coverage Δ
provider-base 18.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hook25 Hook25 merged commit d1a08f6 into main Jun 24, 2024
14 checks passed
@Hook25 Hook25 deleted the fix-snappy-list-uc24 branch June 24, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants