Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert wan/3gpp-scan test as a automated test (New) #1323

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Conversation

stanley31huang
Copy link
Collaborator

@stanley31huang stanley31huang commented Jul 5, 2024

Description

Convert wan/3gpp-scan test as a automated test (New)

Resolved issues

OEMQA-4494

Documentation

N/A

Tests

Please refer following submission for the test results (w/ side loaded provider)
https://certification.canonical.com/hardware/202302-31253/submission/379312/ (Updated on 2024/07/08)

convert 3gpp scan test to automated test
convert 3gpp scan test to automated test
add dependency
add test job dependency
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.23%. Comparing base (d62c028) to head (fc2c59e).
Report is 14 commits behind head on main.

Files Patch % Lines
providers/base/bin/wwan_tests.py 95.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   44.18%   44.23%   +0.05%     
==========================================
  Files         359      359              
  Lines       38813    38853      +40     
  Branches     6581     6584       +3     
==========================================
+ Hits        17148    17187      +39     
- Misses      21003    21004       +1     
  Partials      662      662              
Flag Coverage Δ
provider-base 18.77% <95.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add one more unit test
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments below, and a change request to use template-ids instead of regex in the test plans.

providers/base/units/wwan/test-plan.pxu Outdated Show resolved Hide resolved
providers/base/units/wwan/test-plan.pxu Outdated Show resolved Hide resolved
providers/base/bin/wwan_tests.py Outdated Show resolved Hide resolved
providers/base/tests/test_wwan_tests.py Outdated Show resolved Hide resolved
stanley31huang and others added 3 commits July 8, 2024 13:27
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
re-structure the 3gpp scan test
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for applying all the changes we discussed here and on Mattermost!

@pieqq pieqq merged commit 5508989 into main Jul 23, 2024
13 checks passed
@pieqq pieqq deleted the auto_3gpp_scan_test branch July 23, 2024 13:25
pedro-avalos pushed a commit that referenced this pull request Jul 29, 2024
- Add a `3gpp-scan` subcommand to the wwan_tests.py script
- Create a new `wwan/3gpp-scan-{manufacturer}-{model}-{hw_id}-auto` template job to automatically scan available GSM connections using the new subcommand

---------

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants