Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest units to expand output (New) #1489

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Add manifest units to expand output (New) #1489

merged 5 commits into from
Sep 27, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Sep 19, 2024

Description

We need a way to programmatically fetch the list of manifest entries needed to run a test plan. This makes it easier to automatically verify manifests in CI, track changes to testplans manifest entries and more. This adds manifest units to the expand command filtering out those that aren't used in the testplan.

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1555

Documentation

This adds plenty comments to the expander.

Tests

WIP

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (0881101) to head (570c8c6).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
checkbox-ng/checkbox_ng/launcher/subcommands.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   45.87%   45.88%   +0.01%     
==========================================
  Files         367      367              
  Lines       39156    39167      +11     
  Branches     6622     6628       +6     
==========================================
+ Hits        17961    17970       +9     
- Misses      20504    20505       +1     
- Partials      691      692       +1     
Flag Coverage Δ
checkbox-ng 68.14% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pieqq
pieqq previously approved these changes Sep 23, 2024
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments in _get_relevant_manifest_units, otherwise that would be pretty complicated to parse!

I've played with it a little bit and it seems to do what it's advertised for.

I only have one inline comment about the fact that now every job has a template_id attribute, even if it's null.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hook25 Hook25 merged commit 0463efb into main Sep 27, 2024
47 of 48 checks passed
@Hook25 Hook25 deleted the expand_manifests branch September 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants