Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wwan-automated nested part in SRU test plan (bugfix) #1499

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Sep 24, 2024

WARNING: This modifies com.canonical.certification::sru-server

Description

Replace mobilebroadband-cert-automated with wwan-automated nested part, as the wwan-automated test plan includes better coverage for WWAN-related tests.

Add after-suspend-wwan-automated counterpart to make sure there are no issues with WWAN after resuming from suspend.

This is a follow-up to work done by QA in the certification-client desktop test plans (see #821)

IMPORTANT: PR #1500 is required before merging this.

Resolved issues

Fix CER-2738

Documentation

Tests

Used checkbox-cli expand com.canonical.certification::sru to generate the list of executed jobs and templates before and after applying this patch. The diff is the following:

$ diff /var/tmp/cer-2738-before.log /var/tmp/cer-2738-after.log 
2a3
> Job 'com.canonical.certification::after-suspend-wwan/detect'
74,75d74
< Job 'com.canonical.certification::mobilebroadband/cdma_connection'
< Job 'com.canonical.certification::mobilebroadband/gsm_connection'
140a140,143
> Template 'com.canonical.certification::wwan/3gpp-scan-manufacturer-model-hw_id-auto'
> Template 'com.canonical.certification::wwan/check-sim-present-manufacturer-model-hw_id-auto'
> Job 'com.canonical.certification::wwan/detect'
> Template 'com.canonical.certification::wwan/gsm-connection-manufacturer-model-hw_id-auto'

showing that:

  • a modem detection job is run before and after suspend
  • a job to check if a SIM card is present is added
  • a job to scan the 3g++ connections available is added
  • an automated GSM connection job is still present to replace the one used in the mobilebroadband test plan

@pieqq pieqq marked this pull request as draft September 24, 2024 12:17
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (ba4bbb7) to head (a4dfe62).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files         369      369           
  Lines       39596    39596           
  Branches     6691     6691           
=======================================
  Hits        18833    18833           
  Misses      20051    20051           
  Partials      712      712           
Flag Coverage Δ
provider-sru 97.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Replace mobilebroadband-cert-automated with wwan-automated nested part,
as the wwan-automated test plan includes better coverage for
WWAN-related tests.

Add after-suspend-wwan-automated counterpart to make sure there are no
issues with WWAN after resuming from suspend.

This is a follow-up to work done by QA in the certification-client
desktop test plans (see #821)

Fix CER-2738
@pieqq pieqq force-pushed the CER-2738-wwan-nested-part-in-sru branch from 42021c6 to a4dfe62 Compare October 1, 2024 11:29
@pieqq pieqq marked this pull request as ready for review October 1, 2024 11:29
Copy link
Contributor

@boukeas boukeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pieqq pieqq merged commit 17ceef1 into main Oct 2, 2024
41 checks passed
@pieqq pieqq deleted the CER-2738-wwan-nested-part-in-sru branch October 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants