Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workflow dispatch checkbox from source into action (infra) #1517

Merged
merged 23 commits into from
Oct 2, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Sep 30, 2024

Description

This refactors the Checkbox from source workflow into an action (that is now used by the workflow).

This also implements the following changes:

  • Support for noprovision systems
  • New launcher override parameter (for the action) to provide secrets/envvars/manifest overrides
  • New zapper channel to specify the zapper snap to use

Resolved issues

I think this is satisfactory conclusing to this spike.

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1583

Documentation

New parameter documented as the others in the action header

Tests

Run that executes the zapper-canary testplan dispatched with the following command:

gh workflow run dispatch_lab_job.yaml --ref action_checkbox -f 'matrix_to_create=[{"queue":"202203-30003","match":".*","test_plan":"com.canonical.certification::canary-zapper"}]'

https://github.com/canonical/checkbox/actions/runs/11106549363/job/30855120456

Final, post all commits/refactorings/landing version:
https://github.com/canonical/checkbox/actions/runs/11144034945/job/30970401973

Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and super helpful.

Also, thanks for adding support for noprovision devices, and in general to skip provisioning.

.github/actions/checkbox_source_deb/action.yaml Outdated Show resolved Hide resolved
.github/actions/checkbox_source_deb/action.yaml Outdated Show resolved Hide resolved
@Hook25 Hook25 force-pushed the action_checkbox branch 2 times, most recently from 7f4399b to 3c35c9e Compare October 2, 2024 08:56
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the action from a different repo and everything works as expected.

@Hook25 Hook25 merged commit 92a28be into main Oct 2, 2024
7 checks passed
@Hook25 Hook25 deleted the action_checkbox branch October 2, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants