-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make workflow dispatch checkbox from source into action (infra) #1517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean and super helpful.
Also, thanks for adding support for noprovision
devices, and in general to skip provisioning.
2637044
to
c12db89
Compare
c12db89
to
d70f1bb
Compare
c29c6cc
to
54e2b4a
Compare
7f4399b
to
3c35c9e
Compare
3c35c9e
to
b1e110f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the action from a different repo and everything works as expected.
Description
This refactors the Checkbox from source workflow into an action (that is now used by the workflow).
This also implements the following changes:
Resolved issues
I think this is satisfactory conclusing to this spike.
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1583
Documentation
New parameter documented as the others in the action header
Tests
Run that executes the
zapper-canary
testplan dispatched with the following command:https://github.com/canonical/checkbox/actions/runs/11106549363/job/30855120456
Final, post all commits/refactorings/landing version:
https://github.com/canonical/checkbox/actions/runs/11144034945/job/30970401973