Test Jobs for V4L2 Compliance (New) #1653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1653 +/- ##
==========================================
+ Coverage 48.96% 49.00% +0.04%
==========================================
Files 371 373 +2
Lines 40296 40332 +36
Branches 6808 6816 +8
==========================================
+ Hits 19730 19764 +34
- Misses 19846 19847 +1
- Partials 720 721 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tomli380576
commented
Jan 9, 2025
|
|
||
| def main(): | ||
| udev_out = sp.check_output( | ||
| "udev_resource.py -f CAPTURE", universal_newlines=True, shell=True |
There was a problem hiding this comment.
I'm not really sure if this is the correct way to access udev outputs inside a resource job since it uses shell=True. What would be the better way to do this? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements test jobs utilizing the v4l2 compliance parser. Each camera will get a job for each ioctl request, so the total number of jobs would be (n_cameras * n_ioctl_tests).
Resolved issues
Documentation
As of right now each camera will run v4l2-compliance once for every ioctl request. To test more ioctls in 1 run, pass in more ioctl names in --ioctl.
Tests
Unit tests
Test plan tested on 18, 20 VM with camera pass through, 22&24 DUTs with USB cameras.