-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the Checkbox Edge validation process (Infra) #755
Conversation
Looks like the mermaid diagrams need to be opted out from the spellcheck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this detailed explanation!
A few comments here, and others inline:
- The new pages are put in the How To section of the documentation, but I think they would be better in the Reference section, because they are not really step-by-step instructions you can follow to achieve something: it's a process that's already in place, and that you explain (theoretical knowledge that serves our work)
- There is no proper introduction to the whole thing, so it's very hard for anyone who's not from the team to understand what is “Canary Testing for Checkbox Edge Version”.
Both make spelling
and make linkcheck
complain.
ec464ef
to
f240504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the doc/diagram since the consensus is now to make use of a beta validation branch rather than a edge validated tag.
* add spelling check exception * edit format and wording * move validation docs to explanation/ * add mermaid css for accessbility
f240504
to
03d6daa
Compare
Updated the already stale info about validation outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks for this!
…anonical#755) * add canary validation process documentation * add missing newline * wip * movement * proper diagram * add sphinx plugin that enables mermaid diagrams * add the validation flow diagrams * add description to subpages * suggest changes to Canary validation docs (infra) (canonical#887) * add spelling check exception * edit format and wording * move validation docs to explanation/ * add mermaid css for accessbility * remove unnecessary TOC * fill the missing things in canary explanation * Use proper name for GitHub * Fix the info about the canary TP * Add explanation to what the `dearest team` queue is * update the info about validation outcome (tag->beta shift) * remove mention of metabox on dailies --------- Co-authored-by: tang-mm <3333407+tang-mm@users.noreply.github.com>
…anonical#755) * add canary validation process documentation * add missing newline * wip * movement * proper diagram * add sphinx plugin that enables mermaid diagrams * add the validation flow diagrams * add description to subpages * suggest changes to Canary validation docs (infra) (canonical#887) * add spelling check exception * edit format and wording * move validation docs to explanation/ * add mermaid css for accessbility * remove unnecessary TOC * fill the missing things in canary explanation * Use proper name for GitHub * Fix the info about the canary TP * Add explanation to what the `dearest team` queue is * update the info about validation outcome (tag->beta shift) * remove mention of metabox on dailies --------- Co-authored-by: tang-mm <3333407+tang-mm@users.noreply.github.com>
Description
The PR enables mermaid diagram rendering in our docs.
This PR introduces a handful of pages describing how we validate edge build of Checkbox.
See individual added pages for details.
When testing the documentation make sure to run
make clean; make install
first in the docs folder as it needs to add the sphinx-mermaid extensions.