mock the RemoteSessionAssistant entirely (BugFix) #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissiel
changed the title
Hook25
approved these changes
Oct 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 34.67% 34.57% -0.11%
==========================================
Files 302 302
Lines 34162 34162
Branches 5910 5910
==========================================
- Hits 11847 11812 -35
- Misses 21749 21784 +35
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the unit tests not fully mocking parts of the remote assistant object, which made it run subprocess in the host system.