Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md (Infra) #922

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Update CONTRIBUTING.md (Infra) #922

merged 4 commits into from
Jan 10, 2024

Conversation

jocave
Copy link
Collaborator

@jocave jocave commented Jan 9, 2024

Description

Modified the English of the code review section for readability, but no intent to change meaning.

Resolved issues

None, opinion on documentation only.

Documentation

n/a

Tests

N/a

Modified the English of the code review section for readability, but no intent to change meaning.
kissiel
kissiel previously approved these changes Jan 9, 2024
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few bits myself

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Hook25 Hook25 changed the title Infra: Update CONTRIBUTING.md Update CONTRIBUTING.md (Infra) Jan 10, 2024
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
jocave and others added 2 commits January 10, 2024 11:32
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
Copy link
Collaborator

@mz2 mz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, addresses review feedback too. Merging =>

@mz2 mz2 merged commit 3061592 into main Jan 10, 2024
4 checks passed
@mz2 mz2 deleted the code-review-criteria-mods branch January 10, 2024 11:46
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
* Update CONTRIBUTING.md
Modified the English of the code review section for readability, but no intent to change meaning.
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
* Update CONTRIBUTING.md
Modified the English of the code review section for readability, but no intent to change meaning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants